feat(icon sync): manage syncronization icon#155
Merged
Conversation
ArceDanielShok
approved these changes
Apr 21, 2025
…/node-win into feat/manage-syncronization-icon
| } | ||
| } | ||
|
|
||
| // Función para obtener el mensaje de error de HRESULT |
Contributor
There was a problem hiding this comment.
Not sure if this comment is necessary since the function name describes well what it does, but in any case, we should put comments in english.
| } | ||
|
|
||
| // Obtener un handle al archivo | ||
| // print fullPath |
Contributor
There was a problem hiding this comment.
And maybe this one isn't necessary either. I think wprintf with fullPath.c_str() is self-explanatory.
…/node-win into feat/manage-syncronization-icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.